Toby Inkster avatar Toby Inkster committed 35852d3 Merge

merge changes from shlomif

Comments (0)

Files changed (4)

     to XML::LibXML::NodeList such as sort, map, grep, etc.
         - https://bitbucket.org/shlomif/perl-xml-libxml/pull-request/11/xml-libxml-nodelist-improvements
         - Thanks, Toby!
+    - Printed some warnings regardless if DEBUG is on.
+        - Thanks to http://search.cpan.org/~mstrout/ for the suggestion.
 
 1.90            Sun Jan  8 20:57:58 IST 2012
     - Pull a commit from Aaron Crange to fix compilation bugs in Devel.xs:
             }
 
             if ( not defined $config{LIBS} and not defined $config{INC} ) {
-                warn "\nusing fallback values for LIBS and INC\n";
+                warn "didn't manage to get libxml2 config, guessing\n";
                 $config{LIBS} = '-L/usr/local/lib -L/usr/lib -lxml2 -lm';
                 $config{INC} = '-I/usr/local/include -I/usr/include';
                 print <<"OPT";
     );
 
     my $def_opt = defined($opt) ? $opt : '';
-    # I am not shure if OTHERLDFLAGS is really required - at least the
+    # I am not sure if OTHERLDFLAGS is really required - at least the
     # libraries to include do not belong here!
     # I would assume a user to set OTHERLDFLAGS in the %config if they are
     # really required. if done so, we don't have to pass them here ...
     my $result = eval {
         try_link0(@_);
     };
-    warn $@ if $DEBUG && $@;
+    warn $@ if $@;
     chdir($start_dir);
     rm_fr(".testlink");
     return $result;
  *
  * this function is pretty neat, since you can read in well balanced 
  * strings and get a list of nodes, which can be added to any other node.
- * (shure - this should return a doucment_fragment, but still it doesn't)
+ * (sure - this should return a doucment_fragment, but still it doesn't)
  *
  * the code is pretty heavy i think, but deep in my heard i believe it's 
  * worth it :) (e.g. if you like to read a chunk of well-balanced code 
  * @encoding: this value is missing in libxml2's doc structure
  *
  * Since XML::LibXML will not know, is a certain node is already
- * defined in the perl layer, it can't shurely tell when a node can be
+ * defined in the perl layer, it can't surely tell when a node can be
  * safely be removed from the memory. This structure helps to keep
  * track how intense the nodes of a document are used and will not
  * delete the nodes unless they are not refered from somewhere else.
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.