Commits

Toby Inkster committed ebc6c67

The hashref kept in the fieldhash should not be weakened.

Comments (0)

Files changed (1)

     # Perl 5.8, but XML-LibXML already dropped support for older
     # Perls since XML-LibXML-1.77.
     use Hash::FieldHash qw();
-    use Scalar::Util qw();
     my %tiecache;
     BEGIN {
         Hash::FieldHash::fieldhash(%tiecache);
-        *__HAS_WEAKEN  = defined(&Scalar::Util::weaken)
-            ? sub () { 1 }
-            : sub () { 0 };
     };
     sub getAttributeHash {
         my $self = shift;
         if (!exists $tiecache{ $self }) {
             tie my %attr, 'XML::LibXML::AttributeHash', $self, weaken => 1;
             $tiecache{ $self } = \%attr;
-            if ( __HAS_WEAKEN ) {
-                Scalar::Util::weaken($tiecache{ $self });
-            }
         }
         return $tiecache{ $self };
     }
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.