Pull requests

#21 Declined
Repository
Deleted repository
Branch
default (cd7976dba5af)
Repository
shlomif/perl-XML-LibXML perl-XML-LibXML
Branch
default

Changed unique_key to uniqueKey for consistency

Author
  1. garfieldnate
Reviewers
Description

I realized after I sent the last pull request that I hadn't used camelCasing like almost all of your other methods. If this is an unnecessary change, feel free to ignore it.

  • Learn about pull requests

Comments (1)

  1. Shlomi Fish repo owner

    Hi,

    I believe the camelCase methods are those that are part of the DOM and/or libxml2 API, and mirrored there, and we should use "words_sep_by_underscores" for methods that are our own extensions.

    So I'm going to decline this pull request. Sorry.

    Regards,

    -- Shlomi Fish