1. shuerhaaken
  2. xnoise

Commits

shuerhaaken  committed 5d54729

updates; fix some warnings

  • Participants
  • Parent commits ca9a3dc
  • Branches master

Comments (0)

Files changed (16)

File INSTALL

View file
 Installation Instructions
 *************************
 
-Copyright (C) 1994-1996, 1999-2002, 2004-2011 Free Software Foundation,
+Copyright (C) 1994-1996, 1999-2002, 2004-2013 Free Software Foundation,
 Inc.
 
    Copying and distribution of this file, with or without modification,
 Basic Installation
 ==================
 
-   Briefly, the shell commands `./configure; make; make install' should
-configure, build, and install this package.  The following
+   Briefly, the shell command `./configure && make && make install'
+should configure, build, and install this package.  The following
 more-detailed instructions are generic; see the `README' file for
 instructions specific to this package.  Some packages provide this
 `INSTALL' file but do not implement all of the features documented
 overridden in the site shell script).
 
 Unfortunately, this technique does not work for `CONFIG_SHELL' due to
-an Autoconf bug.  Until the bug is fixed you can use this workaround:
+an Autoconf limitation.  Until the limitation is lifted, you can use
+this workaround:
 
-     CONFIG_SHELL=/bin/bash /bin/bash ./configure CONFIG_SHELL=/bin/bash
+     CONFIG_SHELL=/bin/bash ./configure CONFIG_SHELL=/bin/bash
 
 `configure' Invocation
 ======================
 
 `configure' also accepts some other, not widely useful, options.  Run
 `configure --help' for more details.
-

File libxnoise/DockableMedia/History/xnoise-lastplayed-treeview-model.vala

View file
                     Source.remove(search_idlesource);
                 search_idlesource = Timeout.add_seconds(1, () => {
                     this.filter();
-                    this.search_idlesource = 0;
+                    search_idlesource = 0;
                     return false;
                 });
             }

File libxnoise/DockableMedia/MostPlayed/xnoise-mostplayed-treeview-model.vala

View file
                     Source.remove(search_idlesource);
                 search_idlesource = Timeout.add_seconds(2, () => {
                     this.filter();
-                    this.search_idlesource = 0;
+                    search_idlesource = 0;
                     return false;
                 });
             }
                     Source.remove(search_idlesource);
                 search_idlesource = Timeout.add(200, () => {
                     this.filter();
-                    this.search_idlesource = 0;
+                    search_idlesource = 0;
                     return false;
                 });
             }

File libxnoise/DockableMedia/StreamListing/xnoise-treeview-streams-model.vala

View file
                     Source.remove(search_idlesource);
                 search_idlesource = Timeout.add_seconds(1, () => {
                     this.filter();
-                    this.search_idlesource = 0;
+                    search_idlesource = 0;
                     return false;
                 });
             }
                     Source.remove(search_idlesource);
                 search_idlesource = Timeout.add(200, () => {
                     this.filter();
-                    this.search_idlesource = 0;
+                    search_idlesource = 0;
                     return false;
                 });
             }

File libxnoise/DockableMedia/VideoListing/xnoise-treeview-videos-model.vala

View file
                     Source.remove(search_idlesource);
                 search_idlesource = Timeout.add_seconds(1, () => {
                     this.filter();
-                    this.search_idlesource = 0;
+                    search_idlesource = 0;
                     return false;
                 });
             }
                     Source.remove(search_idlesource);
                 search_idlesource = Timeout.add(200, () => {
                     this.filter();
-                    this.search_idlesource = 0;
+                    search_idlesource = 0;
                     return false;
                 });
             }
                             uri_array += s;
                         thumbnailer.queue_uris(uri_array);
                         uri_list = null;
-                        thumbnailer_src = 0;
                         return false;
                     });
                 }

File libxnoise/ExtraWidgets/AlbumArtView/xnoise-albumart-view.vala

View file
     private int w = 0;
     private int w_last = 0;
     private bool set_column_count_idle() {
+        col_count_source = 0;
         w = this.get_allocated_width();
         if(w == w_last) {
             col_count_source = 0;
         this.set_columns(3);
         this.set_columns(-1);
         w_last = w;
-        col_count_source = 0;
         return false;
     }
 

File libxnoise/ExtraWidgets/VideoScreen/xnoise-videoscreen.vala

View file
         if(redraw_source != 0)
             Source.remove(redraw_source);
         redraw_source = Timeout.add(300, () => {
-            queue_draw();
             redraw_source = 0;
+            queue_draw();
             return false;
         });
-        if(refresh_source != 0)
+        if(refresh_source != 0) {
             Source.remove(refresh_source);
-        
+            refresh_source = 0;
+        }
         refresh_source = Timeout.add(500, () => {
             var job = new Worker.Job(Worker.ExecutionType.ONCE, this.load_image_job);
             io_worker.push_job(job);
     }
 
     private void on_image_changed() {
-        if(refresh_source != 0)
-            Source.remove(refresh_source);
-        if(redraw_source != 0)
+        if(redraw_source != 0) {
             Source.remove(redraw_source);
+            redraw_source = 0;
+        }
         
+        if(refresh_source != 0) {
+            Source.remove(refresh_source);
+            refresh_source = 0;
+        }
         refresh_source = Timeout.add(500, () => {
+            refresh_source = 0;
             var job = new Worker.Job(Worker.ExecutionType.ONCE, this.load_image_job);
             io_worker.push_job(job);
-            refresh_source = 0;
             return false;
         });
     }

File libxnoise/ExtraWidgets/xnoise-trackinfo-bar.vala

View file
             if(global.player_state != PlayerState.STOPPED)
                 //offset in seconds
                 this.player.request_time_offset((event.direction == Gdk.ScrollDirection.DOWN) ? -10 : 10);
+            scroll_source = 0;
             return false;
         });
         return true;

File libxnoise/Lyrics/xnoise-lyrics-view.vala

View file
             GLib.Source.remove(source);
         source = Idle.add( () => {
             set_text(text);
+            source = 0;
             return false;
         });
     }

File libxnoise/Parameter/xnoise-parameter.vala

View file
             //write settings of type integer to hashtable
             string[] groups;
             groups = kf.get_keys(settings_int);
-            foreach(string s in groups)
-                ht_int.insert(s, kf.get_integer(settings_int, s));
+            foreach(string s in groups) {
+                int v = 0;
+                v = kf.get_integer(settings_int, s);
+                ht_int.insert(s, v);
+            }
             //write settings of type double to hashtable
             groups = kf.get_keys(settings_double);
             foreach(string s in groups)
                 ip.write_params_data();
         }
         
-        foreach(string key in ht_int.get_keys())
+        foreach(unowned string key in ht_int.get_keys())
             kf.set_integer(settings_int, key, ht_int.lookup(key));
         
-        foreach(string key in ht_double.get_keys())
+        foreach(unowned string key in ht_double.get_keys())
             kf.set_double(settings_double, key, ht_double.lookup(key));
         
-        foreach(string key in ht_string.get_keys())
+        foreach(unowned string key in ht_string.get_keys())
             kf.set_string(settings_string, key, ht_string.lookup(key));
         
         File f = File.new_for_path(build_file_name());

File libxnoise/Player/xnoise-gst-player.vala

View file
                 if(imarge_src != 0)
                     Source.remove(imarge_src);
                 imarge_src = Timeout.add(500,() => { // TODO: move to io worker
+                    imarge_src = 0;
                     string ar = null;
                     string al = null;
                     if(taglist_buffer == null)
                             });
                         }
                     }
-                    imarge_src = 0;
                     return false;
                 });
                 break;

File libxnoise/TrackList/xnoise-tracklist-model.vala

View file
                     Source.remove(upd_tl_data_src);
                 upd_tl_data_src = Timeout.add_seconds(2, () => {
                     HashTable<TrackListModel.Column,string?> ntags = new HashTable<TrackListModel.Column,string?>(direct_hash, direct_equal);
+                    upd_tl_data_src = 0;
                     if(global.current_uri != null)
                         ntags.insert(Column.ITEM,   global.current_uri); // cheating - the uri is not an item
                     else
                     if(global.current_genre != null)
                         ntags.insert(Column.GENRE,  global.current_genre);
                     // TODO: Add year, tracknumber
-                    upd_tl_data_src = 0;
                     update_tracklist_data(ntags);
                     return false;
                 });

File libxnoise/Utils/xnoise-utilities.vala

View file
         
         try {
             GLib.Regex r = new GLib.Regex("\n");
-            return (owned)r.replace(val, -1, 0, " ");
+            return r.replace(val, -1, 0, " ");
         }
         catch(GLib.RegexError e) {
             print("%s\n", e.message);
             end_idx = prep.length;
         
         prep = prep.substring(start_idx, end_idx - start_idx).replace("_", " ").replace("%20", " ");
-        return (owned)prep;
+        return prep;
     }
 
     public static string replace_underline_with_blank_encoded(string value) {
         try {
             GLib.Regex r = new GLib.Regex("_");
-            return (owned)r.replace(value, -1, 0, "%20");
+            return r.replace(value, -1, 0, "%20");
         }
         catch(GLib.RegexError e) {
             print("%s\n", e.message);

File plugins/azlyrics/xnoise-azlyrics.vala

View file
                     return false;
                 }); 
             }
+            deactivation_source = 0;
             return false;
         });
     }

File plugins/lastfm/xnoise-lastfm.vala

View file
     private bool timeout_elapsed() {
         this.timeout_done = true;
         this.unref();
+        timeout = 0;
         return false;
     }
     

File utils/xnoise-image-extractor-service.vala

View file
         quit_timeout_source = Timeout.add_seconds(QUIT_TIMEOUT, () => {
             print("DONE\n"); // after 60 of inactivity
             loop.quit();
+	    quit_timeout_source = 0;
             return false;
         });
     }