Issue #3111 resolved

The newsfeed is generating public links off of full name instead of username (BB-2837)

Marshall Pierce
created an issue

The newsfeed has avatar images and links for each user. It looks like if a user has a full real name entered, the link generated is based off of that, and the link therefore 404s.

Example: The avatar image for me is in a <a href="/Marshall%20Pierce">. This 404s. /marshallpierce, however, works fine. For users that don't have a full name entered, the link uses their username (not their full name) and it works fine.

Comments (8)

  1. Marshall Pierce reporter

    This is on my newsfeed.

    My wiki edits (and this issue report) correctly use my gravatar and have a photo link that works. My name is also a link. My pushes use an anonymous photo (just the black silhouette) and have a broken link for the photo. My name is not a link. A teammate's pushes have the silhouette and a broken photo link, and his name is not a link. His wiki edits have a gravatar and a correct photo link, but his name is displayed as his username, not his full name.

  2. David Chambers

    What is the user string in your patches?

    See, for example, 5c335463edbc which begins:

    # HG changeset patch
    # User David Chambers <David.Chambers.05@gmail.com>
    

    Bitbucket uses this e-mail address to attribute the commit to me.

    If your patches don't contain an e-mail address in the user string, you'll need to add something like the following to your ~/.hgrc:

    [ui]
    username = David Chambers <David.Chambers.05@gmail.com>
    
  3. Marshall Pierce reporter

    Patches contain

    # HG changeset patch
    # User Marshall Pierce <marshall@palominolabs.com>
    

    Unsurprisingly, that email is configured for work I'm doing for Palomino Labs.

    The email address I use for the bitbucket account is bitbucket@contact.mpierce.org.

    Regardless of what email is configured, it seems like the fact that I pushed with an ssh private key whose public key is in my bitbucket account should be all that's needed to tie it to my account... ?

  4. Log in to comment