Issue #5155 invalid

Create pull request hangs (sometimes) (BB-6399)

gerkey
created an issue

John Hsu

We've seen a problem a few times today where we try to create a pull request and it just hangs there. Specifically, the "Create pull request" button is grayed out and the little busy spinner is spinning, but nothing ever happens, after a very long wait.

The first time it happened, we merged the change manually.

The second time, I merged from the "main" branch that I had branched from and was requesting to pull back to, then tried again to create the pull request and it succeeded. In the meantime there had been some changes on the "main" branch.

Now I'm on the third time and I don't know what to do. There aren't any new changes on the "main" branch to merge in. So I'm stuck.

I'm making the priority critical because pull requests have become a major part of our workflow. They're awesome! But only when they're working...

In particular, at this moment I'm trying to create a pull request from osrf/gazebo/issue_138 to osrf/gazebo/dev.

Comments (8)

  1. gerkey reporter

    OK, I was able to get "unstuck" by first accepting a pending pull request heading for the same branch. Then I was able to create my pull request.

    It seems like the pull request-generator can get into a weird state where it doesn't work, and that it can be kicked out of that state by having changes made to either the source or destination branch.

    Btw, when we're having this problem, the pull request preview page (where the "Create pull request" button is) is working properly, showing us the commits and diffs that would be included.

  2. Gary Sharpe

    This has become a problem for me, too. I've tried making changes on both the origin and the fork, and subsequently attempting the pull request again, but so far have not had any luck. Any one else found a working solution?

  3. Steve Raden

    Happening to me now, just as above "Create pull request" button is grayed out and the little busy spinner is spinning, but nothing ever happens, after a very long wait"

  4. Log in to comment