Changeset viewer intraline changes wrong

Tim Hatch avatarTim Hatch created an issue

Viewing the sub-hunk highlighting isn't working quite right. Lines 73-75 just have s/1/-1/ done do them, so those should be the only intraline changes marked up in that hunk. Instead it shows line 75 being edited to line 73, which is strange.

Screenshot attached.

Comments (3)

  1. Jesper Nøhr

    Hm. Strange indeed. I'm thinking there must be some more modification to that, maybe just not visible (like indentation or the like.) The differ below seems to handle the -1 just fine.

    In any case, the diff is not inherently incorrect, and this is a very granular thing to debug, so I'm probably not going to be looking into this anytime soon.

  2. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.