Online editor does not fire events for hg repositories (BB-8735)

Kaz Nishimura avatarKaz Nishimura created an issue

When I made a change with the online editor, it seemed service integration hooks were not executed.

Comments (27)

  1. Michael Frauenholtz

    Hi Kaz,

    Editing a file online should trigger the service hooks. However, we are investigating an issue for delayed service hooks, which this may be related to. We'll let you know when we have a resolution for this.

  2. Brian Nguyen

    Hi Kaz,

    We have heard a couple of other reports of our services not working properly, so we are investigating this further.

    Can you tell us which services you have configured and the repository that is affected? It would help us greatly.

    Cheers, Brian

  3. Brian Nguyen

    Hi Kaz,

    Looking at that repo, it looks like the push event was lost for that commit. Earlier in the week we were having some issue with our background tasks that may explain this.

    I do not believe that this issue is related to online edit though.

    I'm monitoring our channels to see if the problem is still occurring but unfortunately it is hard to determine the exact error right now. Please let us know if you do see this error again and we will investigate this further.

    Cheers, Brian

  4. Brian Nguyen

    Hi Kaz,

    I believe that the problems with our events has been fixed now, so I'm closing this issue. However, if you are still seeing these issues please reopen this.

    Cheers, Brian

  5. Brian Nguyen

    Hi Kaz,

    Yes, there is a relationship. The mechanism that sends tweets is the same as the one adds items to the activity feed. Unfortunately, once an event has been lost there is no way to recover it. So you won't be able to receive the tweet now.

    However, new events should be working now, so let us know if you see any new occurrences of this bug and we will look into it.

    Cheers, Brian

  6. Kaz Nishimura

    I have no problem for commits via remote push. It happens when I made commits on the online editor. But it could happen when I made a merge from the web UI too. I don't remember well for the merge.

  7. Dan B

    Adding support for this issue. As Kaz says above, the issue of not firing the hooks for a Merge or Sync from the BB Branch Tools (/branches) prevents a key scenario for my team (on Mercurial). We'd like to be able to enable testers to pull the latest DEV code into the TEST branch and thus receive a new build from our CI system (AppHarbor). If we could fire hooks from the Branches page on BB, this would be a one-stop shop for them, but as it is now, our testers have to either do the merge themselves locally or (more likely) have a developer do it. This is highly asymmetrical treatment of the remote push versus an internal push - oddly implemented to my thinking.

    And if this gets worked on, I'd like to suggest a button to "Fire All Hooks" or similar to force external CI listeners to rebuild/etc. This would be a nice-to-have as an effective way to force the rebuild/redeploy of software when making changes to hardware/settings/etc on an external CI provider or to force a rebuild in case of other failure. Not strictly BB's problem, but like I said, making BB a one-stop provider only makes the offering stronger. It would also help hook testing.

    I've also submitted this through Attlassian support (BBS-7460) and they basically told me that I had an interesting idea.

    Issue #8327 appears to be a duplicate of this issue.

  8. Wilko Nienhaus

    I tested this (online editing) yesterday, before the status of this issue was changed to resolved and also after the status was changed to resolved, and sadly no hooks were fired during either attempt.

    The new issue created (#9161) appears to be only vaguely related (of course it might be connected to the underlying reason). I am afraid that the online editor problem might go unfixed, now that both this issue and issue #8327 are effectively closed.

    Is the new issue really the underlying problem, or should this issue rather be reopened?

  9. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.