Issue #7579 new

Unapprove button shouldn't come once the changes are merged (BB-8739)

Surya Tripathi
created an issue

Hey,

When my manager approves for changes made by developer, my web admin merge the changes to the master, but once the changes are merged. Manager can still see and click on unapprove button. Which is not a correct flow IMO. What if manager unapprove after a change is merged, when that change is not correct/ buggy, that eventually removes the approval messages from activity tab, too. Web admin's job is just to merge the changes(i.e. he is not aware of code much, manager does). Once it's approved web admin blindly merges the change. Any idea?

Comments (5)

  1. Zach Davis staff

    Hi Surya,

    I think it's certainly possible that people would want to approve a pull request even after it's been merged. I've added this suggestion to our backlog, but I'm not convinced we want to take away that interaction.

    Cheers, Zach

  2. Surya Tripathi reporter

    Hi Zach,

    My intention of raising this issue is not that people should not see approve button even after a change is merged. My only concern is, when a change is merged, people who have already approved for that pull request, they shouldn't be able to unapprove the same. I hope you understand my point now.

  3. Surya Tripathi reporter

    Hey Joel,

    Yes. Actually, I did. And, I think this shouldn't be the flow. When people have approved for a change to be merged on a branch, when change is merged, people who have already approved shouldn't be able to un approve.

  4. Log in to comment