Issue #7863 duplicate

PR performance problems

John Kodumal
created an issue

Lately, we've been seeing more and more PRs time out with the following error message:

"This merge is too large to display."

This doesn't seem necessarily correlated to merge sizes, for example, this change:

https://bitbucket.org/atlassian/amkt/pull-request/1249/amkt-6663-change-uid-for-atlassian-vendor/diff

is tiny and exhibits the same problem. Other scenarios where we're seeing the problem:

  • PRs with small changes across many files
  • Additions of large files
  • Actual large PRs (typically refactorings)

We'll use this ticket as an umbrella issue to collect more data.

Comments (11)

  1. Ben Woskow

    Hey ddbennett - John told us to attach any Bitbucket PR problems (either performance problems or diff problems) to this issue, but you've closed it. Is there a different place we should attach problems?

    In the mean time: https://bitbucket.org/atlassian/atlassian-upm/pull-request/891/upm-3939-remove-changes-to-pacclient-and/diff

    The PR says "This merge is too large to display." although the PR consists of just a single commit which really isn't that large at all. https://bitbucket.org/atlassian/atlassian-upm/commits/fbcc17f9abfe5bb944d64b38624043a03d95af93

  2. Ben Woskow

    This PR [1] was also too large to display in Bitbucket and had to be reviewed in Stash [2].

    [1] https://bitbucket.org/atlassian/atlassian-upm/pull-request/881/upm-3897-rest-apis-provided-by-the/diff [2] https://stash.atlassian.com/projects/ECO/repos/atlassian-universal-plugin-manager/pull-requests/2/overview

    In addition to not rendering the diff, I've found that Bitbucket PRs don't handle renamed files cleanly. It shows a completely removed file and a completely added file, which makes it difficult to review any additional changes that occurred in the renamed file.

  3. Ben Woskow

    This PR fails to load all of the file diffs as many files and LOC were modified. We have a lot of large PRs like this; this is just one example.

    https://bitbucket.org/atlassian/atlassian-upm/pull-request/854/upm-3875-splitting-representationfactory/diff

    Another thing to point out is that it's fairly difficult to navigate around large PRs because the UI requires me to jump up and down the page if I want to navigate between various files. Several of us on the Ecosystem team find Stash's side-nav with the file listings much easier in this regard.

  4. Log in to comment