Issue #8171 resolved

Large pull requests have major browser performance issues (BB-9318)

Nathan Taylor avatarNathan Taylor created an issue

This is an additional report of this "Invalid" issue.

As above, large pull requests create crippling performance problems in the browser. One of our projects has several pull requests which are so large that even attempting to scroll the page results in a lag of 5+ seconds at times. Typing comments is as bad if not worse.

I cannot link to any of these pull requests as our repo is private, but it appears to be an endemic issue which I deal with on almost every pull request I review. We're using relatively powerful machines (a few years old)

Comments (6)

  1. Zach Davis

    Hi Nathan,

    We're aware of this problem and actively working on short-term solutions (css performance, etc) and thinking through long-term solutions (better ux for large pull requests). We hope to have some fixes out soon that will alleviate this problem.

    Thanks, Zach

  2. Brian Nguyen

    Hi Nathan,

    We've made some performance fixes to address some these issues (particularly for Chrome). Please try it out and let us know if you are still having problems.

    Cheers, Brian

  3. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.