Issue #9094 resolved

Adding user to private repo results in uncaught exception. ugly error! (BB-10202)

Antonio Mercado
created an issue

Looks like you guys are not catching an exception. I tried to add a user to my private repo and resulted in the following error.....

{"error": {"message": "'PaymentRequiredException' object has no attribute 'actor'", "detail": " File \"/opt/python/domains/bitbucket.org/current/bitbucket/local/env/lib/python2.7/site-packages/piston/resource.py\", line 208, in __call__\n result = checked_meth(request, *args, **kwargs)\n File \"/opt/python/domains/bitbucket.org/current/bitbucket/local/env/lib/python2.7/site-packages/piston/resource.py\", line 195, in checked_meth\n return meth(*args, **kwargs)\n File \"/opt/python/domains/bitbucket.org/current/bitbucket/local/env/lib/python2.7/site-packages/newrelic-2.12.0.10/newrelic/hooks/component_piston.py\", line 33, in __call__\n return self._nr_wrapped(*args, **kwargs)\n File \"/opt/python/domains/bitbucket.org/current/bitbucket/../bitbucket/apps/bb/decorators.py\", line 38, in wrap\n return f(request, *a, **kwa)\n File \"/opt/python/domains/bitbucket.org/current/bitbucket/../bitbucket/apps/api/v10/decorators.py\", line 369, in wrapper\n return func(*args, **kwargs)\n File \"/opt/python/domains/bitbucket.org/current/bitbucket/../bitbucket/apps/api/v10/decorators.py\", line 28, in wrapper\n return f(self, request, *args, **kwargs)\n File \"/opt/python/domains/bitbucket.org/current/bitbucket/../bitbucket/apps/api/v10/decorators.py\", line 47, in wrapped_function\n return func(self, request, *args, **kwargs)\n File \"/opt/python/domains/bitbucket.org/current/bitbucket/../bitbucket/apps/api/v10/decorators.py\", line 104, in wrapper\n response = func(*args, **kwargs)\n File \"/opt/python/domains/bitbucket.org/current/bitbucket/../bitbucket/apps/api/v10/decorators.py\", line 440, in _inner\n e.users_required, actor=e.actor)\n File \"/opt/python/domains/bitbucket.org/current/bitbucket/../bitbucket/apps/api/v10/decorators.py\", line 314, in __init__\n can_upgrade = self.actor is not None and is_account_admin(self.user,\n", "id": "a6611e80751d481cbf6cbef4959e90d1"}}

Comments (3)

  1. Antonio Mercado reporter

    It also might be wise for you to obfuscate messages containing server file paths, that can potentially be seen by a user. hackers can have a field day with this info, but i've got faith that your engineers are some of the top in the industry and will handle this like it should.

  2. Dan Bennett staff

    This issue has been resolved. Please re-open this issue if you continue to experience problems. As a bonus, you've also precipitated a security by obscurity vs unnecessary transparency discussion. :)

  3. Dan Bennett staff

    Also, the exception that is being thrown is ultimately that attempting to add another user will put your account over the 5-user limit. You may have to address that first.

  4. Log in to comment