Problems updating pull requests
Hi Erik van Zijst & co!
While chewing wurst, Martin Geisler claimed that pull requests handled updates with modified history badly.
Real world testing on https://bitbucket.org/pypy/pypy/pull-request/254/ confirms it.
My fork is non publishing. I pushed a change, made a PR, got feedback, modified my changeset, and pushed an extra head with force. When editing the PR it shows the new changeset in the list. But when I save it, the actual PR still uses the old PR.
I guess it is fair enough if it only supports "extending" the PR but not "removing" changesets from it ... but then it should show that in the edit ui.
However, I manually stripped the old head. That "broke" the PR more than expected. From what Brodie Rao had told me I thought you stored the context together with the comments ... but since bb no longer shows any context after the changeset has been stripped, I assume that isn't the case.
Anyway, after that I could update the PR to the new changeset.