1. Bitbucket
  2. Public Issue Tracker
  3. master
  4. Issues

Issues

Issue #10103 closed

Problems updating pull requests

Mads Kiilerich
created an issue

Hi Erik van Zijst & co!

While chewing wurst, Martin Geisler claimed that pull requests handled updates with modified history badly.

Real world testing on https://bitbucket.org/pypy/pypy/pull-request/254/ confirms it.

My fork is non publishing. I pushed a change, made a PR, got feedback, modified my changeset, and pushed an extra head with force. When editing the PR it shows the new changeset in the list. But when I save it, the actual PR still uses the old PR.

I guess it is fair enough if it only supports "extending" the PR but not "removing" changesets from it ... but then it should show that in the edit ui.

However, I manually stripped the old head. That "broke" the PR more than expected. From what Brodie Rao had told me I thought you stored the context together with the comments ... but since bb no longer shows any context after the changeset has been stripped, I assume that isn't the case.

Anyway, after that I could update the PR to the new changeset.

Comments (7)

  1. Mads Kiilerich reporter

    Hmm. Now I cannot strip the changesets. Strip "succeeds" with "Strip complete Bundle file not created" - and without stripping. (A bit later I see a "There was an error while executing the strip task." banner.)

    I assume that could be one way of "solving" the problem ... if only the user interaction was improved a bit.

  2. Log in to comment