Details
-
Suggestion
-
Resolution: Duplicate
Description
Large pull requests are hard to review. Individual commits are much simpler. However, comments on a commit are lost when the branch is rebased. So all comments need to be on the pull request. My team makes a lot of use of re-basing when updating branches based on code reviews.
My current workflow:
- Open the pull request in two tabs
- In one tab, go to the commit section, go to a commit, and review the code.
- When I have a comment to make, go to the other tab and find the same change in the "overview" section - add my comment there.
- Repeat. Unless I accidently makea comment on the commit - then delete the comment, re-create it on the pull request.
I would love to see something that makes this workflow a lot simpler.
TL;DR - Allow me to review individual commits, but comment on the overall pull request.