"Ignore whitespace" toggle in the UI (BB-14331)

Issue #11864 resolved
Zachary Davis
created an issue

Many users have requested a way to toggle the "ignore whitespace" option directly from the UI. This is a follow-on from #6024 which provides a query param for ignoring whitespace, but isn't sticky (meaning that it needs to be re-applied to each page view and doesn't follow the user through navigation) and requires manually appending the query param to the url.

Official response

  • Zachary Davis reporter

    Hi everyone,

    We've just released a button on every file in a diff that toggles ignore whitespace for all files in the diff. This option is currently not sticky (the setting isn't remembered on reload or navigation), and there is no account or repo-level setting. Those are both things we considered and explored but ultimately we felt it was better to get this functionality out as it currently stands.

    If you run into any bugs, please let us know, . If you want enhancements, please file new tickets.

    Thanks for your patience,
    Zach

Comments (31)

  1. Paolo Inaudi

    As a suggestion, there should be three levels for this option: in user's settings, to choose a global default for all diffs; at the beginning of the pull request (or branch diff), to enable/disable it for all files in the request; and finally, on a file-by-file basis (along with the button to see side-by-side diff in the default view, and somewhere in the side-by-side diff popup as well).

  2. John Vidar Larring

    For me, the API fix for "Ignore whitespace" (Ref.: #6024) is of no value until a UI option exists. Please bring the whole "Ignore whitespace" issue to an end by implementing a proper UI for it. It would make a big difference!!

    Second Paolo Inaudi suggestion for a three level option: A user setting with global effect, a setting/toggle at the beginning of a pull-request / commit that can override user's global setting, and setting/toggle per diff-file that can override the previous settings.

  3. Kurt Lehrke

    Heh, even more reason that bitbucket (non server) should have it then... Harder to explain why "bitbucket" doesn't contain the same features as "bitbucket server". You'd think they'd be the same thing logically.

  4. StryderC

    The biggest indicator to me that Atlassian doesn't build tools for developers is missing features like this. As a Dev Lead or Architect, I shouldn't have to alter my uri by hand just to get a clearer view of what code has changed in a tool built around reviewing code. +1 this. It's been 2 years and there's still nothing there.

  5. David Bakin

    @StryderC - don't know why you say that. HipChat just got a totally new client for Windows and of course that complete rewrite of a chat utility was way more important to developers and engineering team cohesion than providing a button to add ?w=1 to the end of a url in, what? Some code review tool I use at most several times a day? Your team may be different but I know we couldn't live without official Atlassian support for Giphy in HipChat. Thank goodness Atlassian has got its priorities straight.

  6. David Bakin

    Let me try again without the (well deserved) snark. The issue was opened above with two "requirements": stickiness, and not having to manually append ?w=1 to the url by hand. I'm willing to give up stickiness if I could just get a damn button that I could press once for each page. Doesn't need to follow navigation, doesn't need to be a policy setting on my account or for the team admin to set, doesn't need anything at all really but a stupid button that puts ?w=1 at the end of the url and it would stay set as long as on I'm the page, including expanding/collapsing code sections. (Though I'd give that up too for "version 1".) Is that now a small enough story that it can be added to some sprint in 2016?

  7. Artem Russakovskii

    I've been ever since I started using Bitbucket wondering why in the world it doesn't have an ignore whitespace flag for diffs, and today I found out that it actually does exist https://blog.bitbucket.org/2015/01/30/new-year-new-features but is completely hidden away in the UI. Users are expected to append w=1 to the url.

    This is such a useful feature, and hiding it just doesn't make sense. Please bring it to the UI (check out the comments on the blog post too).

  8. Alex Kwiatkowski

    @Kurt Lehrke Yes & no, I have that plugin installed and it is better than nothing, but it causes so many redirects before the page settles down that a PR is often unusable for 5 seconds after opening it. During that time I can't interact with anything on the page (edit, approve, comments...).

  9. Kurt Lehrke

    You could always let the dev know and help out. He's always looking to make it better / more helpful. That also doesn't happen to me. Redirect happens once for the white space button, but the diff toggle doesn't seem to redirect.

  10. Zachary Davis reporter

    Hi everyone,

    We've just released a button on every file in a diff that toggles ignore whitespace for all files in the diff. This option is currently not sticky (the setting isn't remembered on reload or navigation), and there is no account or repo-level setting. Those are both things we considered and explored but ultimately we felt it was better to get this functionality out as it currently stands.

    If you run into any bugs, please let us know, . If you want enhancements, please file new tickets.

    Thanks for your patience,
    Zach

  11. Zachary Davis reporter

    Hi Jeff,

    Please file a new ticket with details on any additional enhancements you'd like. The overwhelming majority of feedback on this implementation has been positive.

    Cheers,
    Zach

  12. Log in to comment