As a repo admin, I want to restrict the Pull Requests Decline option to specific users

Issue #12509 closed
Theodora Boudale staff created an issue

Problem Definition

At the moment any user with write access to a repo can Decline a Pull Request. A repo admin that wants to control who can Decline a Pull Request currently has no way of doing that.

Suggested Solution

Allow a repo administrator to restrict which users can Decline Pull Requests in that repo.

Comments (10)

  1. Carlos Eduardo Matias Rezende

    Today we can do this by defining user as having only read access to repository, but with that the user can't do pushes.

    What we realy need is some way that no one can decline the pull request.

  2. Alastair Wilkes staff

    Hi @pjweb - can you elaborate on why this specific permission would be useful for your team? It'd be great to learn more. Thanks!

  3. Carlos Eduardo Matias Rezende

    Hi. In our case, all of our developers can push to remote repo, so all of them need to have write permission. However it's not all of them than can decline a pull request, giving that we have several junior developers pushing to repo.

    The way we have today I, as repo admin, can't remove for our junior developers permission to decline a pull request.

    Hope that is clear.

  4. Alastair Wilkes staff

    Hi @pjweb, thank you for your reply. Would you want this permission for both approve and decline (together), or just decline?

  5. Ezequiel Carrizo

    I think that, eventually when you work on this issue, both permissions could be usefull.

    I've worked on an organization that, As developer, first i need to make my pull request to the repository, then two different code reviewers have to approve my pull request in order to let the "Manager" approve a merge.

    So thinking in those roles, the code reviewers could know when a pull request could be declined at all and do so, But only certain "Manager/ubber" users are allowed to approve it.

  6. Alastair Wilkes staff

    Given the low interest in this feature since it was raised, and since the team is currently focused on higher priority items, I am closing this issue to reflect that we won't be able to address this in the near future.

  7. Log in to comment