Bitbucket Cloud needs "Diff" tab on pull requests.

Issue #13455 duplicate
Brian Doyle
created an issue

One of the most useful features of Bitbucket Server is the "Diff" tab on pull requests. It allows reviewers to look file-by-file at each change and make comments so the PR author can fix them.

The Bitbucket Cloud product already shows the Diff tab when a PR is created, but this is only useful to the PR author. To be effective in team environments, contributors also need to be able to review and comment on changes on a file-by-file basis.

I contacted Atlassian support and was told that at the end of each PR is a "files changed" section that shows the changes. Reviewing pages and pages of inline diffs is cumbersome at best, and at worse it is simply broken (see attached photo).

Since the Diff tab already exists for PR submission, it should be trivial to add it to the PR review screen. The utility of this functionality cannot be overstated.

Please enable this feature in Bitbucket Cloud.

I'm filing this as blocking because Bitbucket Cloud implementation is actually broken for large PR's.

bitbucket_cloud_pr.png

Comments (3)

  1. Alastair Wilkes staff
    • changed status to open

    Hi Brian,

    Thanks for taking the time to create this issue. I have a couple of questions, so bear with me.

    Are you asking for a diff (any diff) to be shown on the PR page, or are you requesting the specific rendering style of the Bitbucket Server diff view (which is different, as you mention - see #10963), or both?

    If the request is just for a diff on the PR page, our Support is correct: the same diff we show on the PR creation screen (in the Diff tab) will be displayed on the Overview tab along with the ability to comment, etc.

    In this case, it looks like loading the diff timed out - in this case, did you not receive the same error on the creation screen? They should perform consistently; if they don’t, we’ll take a look.

    I think the main issue here is probably #7723 (Improve performance of large code reviews), with potentially #10963 (Bitbucket Server diff + tree view) as a supplemental request. Would you agree?

    Many thanks,

    Alastair

  2. Log in to comment