Add "Approved By" to MERGED email

Issue #13761 resolved
Clint D created an issue

i noticed that the APPROVED email (bob has approved pull request #100) has an "Also Approved by" section in it. The MERGED emails should have a similar section where when a branch gets MERGED it says: "approved by" or "nobody approved this PR"

Official response

Comments (9)

  1. Alastair Wilkes staff
    • changed status to open

    Hi Clint,

    Thanks for the suggestion. This sounds like a good idea, we'll see if we can add this.


  2. Clint D reporter

    Exciting - i have my first MERGED email with an approved by list... however i have a lot of emails that are merged after getting an approval where the email doesn't show me the approved list.

    Should I just file a bug or should we continue this discussion here?

  3. Alastair Wilkes staff

    Hmm... The release went out right before I posted on this thread, (14 hours ago) and the timestamps in the screenshot say 20 hours ago, so they wouldn't have been included. Are you still getting the issue on merges that happen today?

  4. Log in to comment