Uploaded image for project: 'Bitbucket Cloud'
  1. Bitbucket Cloud
  2. BCLOUD-15090

Exclude commit authors from merge check approval count

    XMLWordPrintable

Details

    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

    Description

      We have found that the PR Merge Check process for Approvals can be subverted by a non-author of the PR.

      How to recreate

      1. Set minimum approvals to 1;
      2. User 1 creates a pull request (User 1 is the Author);
      3. User 2 updates the PR with subversive changes;
      4. User 2 approves the PR and is then able to merge.

      Why is this bad?

      User 2 can add subversive changes, approve and merge.

      What should happen?

      The approval of a commit author should not count towards the merge check approval count.

      Attachments

        Activity

          People

            Unassigned Unassigned
            69c3463c5968 joel
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: