Ability to mark elements of a pull request as OK.

Issue #15108 duplicate
Richard Quadling
created an issue

Imagine you have a PR with several files changed in it.

During review, you make the comments about the changes that will cause you to decline the PR.

The developer fixes the issues and then resubmits a new PR.

You now have to go and examine all the files that are unchanged between the two PRs all over again. It may not be the same reviewer.

It would be REALLY useful to be able to mark files/diff chunks as reviewed, and, if the chunks remain the same between reviews, they are collapsed in some way.

The constant scrolling up and down looking at things which we have no way of ignoring once we've reviewed them, makes it just a little painful to do.

Comments (3)

  1. Alastair Wilkes staff
    • changed status to open

    Hi Richard,

    Thanks for the feedback. I have a question:

    During review, you make the comments about the changes that will cause you to decline the PR.

    The developer fixes the issues and then resubmits a new PR.

    I am curious why you decline the PR here, forcing the developer to submit a new PR. Why not have the developer update the existing PR with new code?

    Regardless - this is good feedback, similar to #7968.

    Thanks!

    Alastair

  2. Richard Quadling reporter

    That's a fair question. We will decline those that are needing a LOT of work to match the requirements. If the reviewer and dev are available at the same time, they'll often amend the code together.

    The issue is about being able to approve elements of the PR and "be done with them", unless they change, in which case the marker's are removed. The granularity could be per file or diff.

  3. Log in to comment