Uploaded image for project: 'Bitbucket Cloud'
  1. Bitbucket Cloud
  2. BCLOUD-16480

Easier mechanism for reviewing pull request changes (after initial review pass)

    XMLWordPrintable

Details

    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

    Description

      The current pull request feature is great for the initial review pass, but it is difficult to review subsequent changes to a pull request (eg. changes made in response to review feedback).

      For longer pull requests, our developers typically make initial pass comments using the pull request, and then review individual commits for subsequent changes. This has a couple problems:

      • If a submitter makes 2 (or more) corrective commits, the second commit may nullify portions of the first. So the reviewer wastes time reviewing (and commenting on) both.
      • Comments on individual commits aren't displayed in the pull requests 'Activity' tab, making it difficult to ensure that all feedback has been addressed.

      Ideas:

      • Possibly some way to set the root commit used for the pull request diff (so reviewers can see only the aggregate result of the subsequent commits that haven't been reviewed yet)
      • Less ideal (but perhaps simpler): Show commit comments in the pull request 'Activity' tab

      Attachments

        Activity

          People

            Unassigned Unassigned
            521d58c566ae Alex Goldberg
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: