Approving pull requests could be more clear

Issue #18538 new
Juho Vainio created an issue

We have had a few issue where the author of a pull request merges the pull request prematurely because they thought that the PR was already approved.

When asked about it they said they saw a green tick icon on the right corner and assumed (without reading) that the PR was approved.

The icon they referred to was the "build succeeded" icon which is deceptively close to the "Approve" button.

So I think the two should be a bit more apart os more cleraly separated.

Comments (1)

  1. Log in to comment