Wrong commit message in source browser with re-added files (BB-1641)

Issue #2712 wontfix
cenk
created an issue

Wrong commit message on re-added files.

{{{ $ echo test > testfile $ hg add adding testfile $ hg ci -m "first commit" $ hg push pushing to xxx ...... yyy is allowed. accepted payload.

$ hg rm testfile $ hg ci -m "removed" $ hg push pushing to xxx ...... yyy is allowed. accepted payload.

$ echo test > testfile $ hg add adding testfile $ hg ci -m "re-add" $ hg push pushing to xxx ...... yyy is allowed. accepted payload. }}}

And then, source browser shows "first commit" message instead of "re-add" message on testfile.

Comments (4)

  1. Brodie Rao

    OK, I've taken a look at this more in-depth and I'm not sure we can fix it easily.

    The problem is that we're using special metadata that Mercurial provides that tells us what changeset last modified each file's contents. That metadata does not tell us anything about the file being removed or re-added, and getting that information would involve traversing a whole lot of history.

    In other words, fixing this would make the source browser unusably slow. In light of this, I'm closing this as won't fix -- it's just not practical to work around it.

  2. Log in to comment