Issue #2855 resolved

Paragraphs and line-breaks in commit messages (BB-2079)

Martin Geisler
created an issue

It is quite cool that you parse commit messages for paragraphs, but the {{{<br/>}}} tags you insert make them look poor: there is a lot of extra space between the lines. I noticed this with

https://bitbucket.org/aragost/hglock/changeset/019d137a6ece

Comments (4)

  1. Anonymous

    +1 for this. Since I manually wraps my commit messages to 80 characters strings this bug is very annoying for me.

  2. David Chambers

    We've just deployed a fix for this, which turned out to be trivial:

    -        paragraphs.append(u'<br />\n'.join(paragraph.splitlines()))
    +        paragraphs.append(u'<br />'.join(paragraph.splitlines()))
    

    The problem arose from the fact that in preformatted text, newlines are preserved. <br />\n thus inserts not one but two significant line breaks in this context.

    Thanks again for the bug report, Martin.

  3. Log in to comment