Issue #2884 resolved

Pull request allow specification of destination branch, which is ignored (BB-2125)

Palmer, 2E0EOL
created an issue

In order to reproduce this issue, create a repository, create default and develop branches, and then folk the repository. Once forked, work on a new feature branch in the clone, and then send a pull request from the new branch, specifying develop as the destination branch.

Although you ask asked for a commit message, inspection of the parent repository will reveal that the merge happened on the default branch, regardless of the fact you have specified that develop is the destination branch.

If you are using named branches, this means that it is not possible to use this feature.

Comments (2)

  1. Brodie Rao staff

    I've just put out a fix for this.

    Our in-memory merge algorithm was doing everything correctly except for one thing: it neglected to mark the merge commit as being on the correct destination branch -- it was defaulting to the default branch. It should now properly take the branch of the destination (the first parent in the merge).

    Sorry for the inconvenience, and thanks for the report!

  2. Log in to comment