1. Bitbucket
  2. Public Issue Tracker
  3. master
  4. Issues

Issues

Issue #3506 resolved

Unable to decline a pull request I made from a deleted fork (BB-15376)

Atlassian Tutorials
created an issue

I should be able to decline a pull request that I made. We don't seem to be able to do this. I ran into the same odd thing when I first started working with pull requests. A tutorial user brought it up again just recently.

Comments (66)

  1. Jacek Pakulski

    This is not resolved! We often "finish" our features using git flow (deleting the remote branch) after a pull request is approved.

    This might not fit with the flow You envisioned.

    Still, after the remote branch is deleted, the only way to "delete" the pull request is to decline it which is confusing because it was actually approved.

    BTW, updating a pull request with the remote branch deleted causes a raw json error. I'll create a new bug for that.

    Cheers

  2. Fergus Morrow

    I echo what Jacek Pakulski has expressed; when working on repositories which use git flow this can be quite annoying! (Although, attempting to merge it using the Pull Request UI doesn't seem to do any harm as per se, it does (at the very least) force you to deviate from your usual workflow.)

    I find this quite surprising considering the Git Flow integration provided by Atlassian's SourceTree application! (Which is a pretty good app.)

  3. Kevin Meixner

    I also would like the ability to cancel a pull request. I created a pull request the other day but realized I had a bug in my code after creating the pull request, I had no way to cancel it while I worked on fixing the bug. My coworkers are complaining that the code wasn't ready to be pushed to production when I made the pull request.

  4. Anonymous

    I do also think that cancelling a pull request is a necessary feature and that this is not resolved yet.

  5. Mark Faine

    Me too. I don't understand why this hasn't been resolved yet. I submitted a problem report but was told that it was by design:

    We do not implement deleting pull requests. While we do not intend for the Pull Request to be deletable as it is part of the permanent record of the repository, there exist work-arounds to accomplish many of the same goals that deleting a Pull Request would accomplish.

    I'll update if I find out anything more.

  6. Anonymous

    I understand what they want to tell us with "it is part of the permanent record of the repository", and I agree on that. But this should only be the case for approved and merged or declined PRs. What if you accidentially created a PR set to the wrong destination? Or the improvement/fix you did on your branch has already been checked out into another branch and that other branch was merged before yours?

  7. Chris Chrisostomou

    +1. I see the logic in wanting to keep a history of pull requests, but as the application owner if I decide that having this history item is of no relevance to me, then all it becomes is noise

  8. Alastair Houghton

    Likewise. I created a pull request for a change I thought I wanted to make in a third-party module, realised that there were other problems that made my pull request rather pointless (and had to not use that third-party module as a result, since fixing these problems was too time-consuming), and deleted the forked repo, only to find that I still have an outstanding pull request (with a deleted repo) against that third-party project. It would be nice to be able to tidy it up somehow…

  9. Stephen Sykes

    Yep. Testing something, made a mistake, the pull request is specious, should just disappear. Why do you force your workflow instead of supporting ours? We want to delete a pull request - let us!

  10. peterbuzzcapture

    I sense a reluctance from devs to create a useful feature. Functionality should match user experience. PRs should be allowed to be created, accepted, canceled, rejected, and put on hold. Not that none of these imply deleting the PR in the repo records.

  11. Stephen Sykes

    Sometimes they're just wrong and need to be redone - and detritus in the record is not a good thing.

    For god's sake, when will engineering stop second guessing users? Classic problem.

  12. Ben de Bruyn

    Somebody created a wrong pull request and now it is linked to almost all our JIRA-issues, sadly, there is no possibility to fully remove a pull request. +1 for this feature.

  13. Luc Mousseau

    Zachary Davis I'm a bit confused by your change of this to "Decline" versus "Delete". Others can weigh in, but I think what people want here is some way for the to remove a Pull Request from history permanently, as if it was never created (probably because they made a mistake in creating it, or decided it wasn't necessary). And besides you can already "Decline" a pull request whether or not you're the creator of said pull request. I still think this should be "Delete"...

    If you want to add some limitations to when a PR can / cannot be deleted: ie: if comments were made, then you can't delete it, or perhaps some sort of delay delete, or require some project level "admin"/"owner" approval for completing a delete... then I think most would probably consider that acceptable. But the end result should be the complete elimination of the PR.

  14. Zachary Davis

    I changed the title in an attempt to avoid exactly this sort of confusion going forward. I was certainly confused at first.

    As noted, another issue (#8089) is about deleting a pull request. This issue is, or at least was originally, about not being able to properly decline a pull request in some situations (namely when you're the author of the pull request from a fork that has been deleted). I suggest everyone who is interested in deleting a pull request watch issue #8089 instead of this one.

  15. Zachary Davis

    To be clear, the problem as initially reported was indeed fixed. I know for sure because it was reported by a Bitbucket team member.

    If you read my comment above you'll note that I renamed the issue to avoid this confusion, not to "whitewash" the issue. There was an actual bug with declining pull requests that has now been fixed.

    If you care about DELETING pull requests, please vote for or comment on issue #8089
    https://bitbucket.org/site/master/issues/8089/allow-a-pull-request-to-be-deleted-bb-9221

  16. Log in to comment