Issues

Issue #4952 wontfix

if one file diff is too big to render, prevents any from displaying

Jacob Dorman
created an issue

Files Changed (19)

+27 -16396 .DATABASE/db.sql

+1 -0 .gitignore

+0 -0 modules/mod_image_show_gk4/styles/style/images/banner_btn_read_more.png

+4 -5 modules/mod_image_show_gk4/styles/style/style.css

.DATABASE/db.sql

This diff is too big for us to render.

this is shown for each file (with .DATABASE/db.sql filename, not actual filenames)

.DATABASE/db.sql

This diff is too big for us to render.

.DATABASE/db.sql

This diff is too big for us to render.

.DATABASE/db.sql

This diff is too big for us to render.

Comments (6)

  1. Dylan Etkin

    Hi JDorman,

    We try our best to render the diff on the server-side. We have a total amount of time that the server is allowed to spend calculating the diff.

    If the calculation exceeds that time then we don't try to render the rest of the diff.

    This is done so we do not DOS our servers trying to render gigantic diff's. We believe that we have allowed for a reasonable amount of time to render most normal sized diff's.

    I understand the experience is not perfect but it is the compromise we have chosen so that we can provide a reliable and scalable service to all.

    Cheers,

    Dylan

  2. Jacob Dorman reporter

    I understand that, and think it is an improvement on the last version that would bog down while loading huge diffs.

    but this is a different bug.

    Say you have 5 files, and the first file diff is too big to render. You will get 5 notifications that say exactly the same thing, that FILE 1 is too big to render.

    eg., FILE1.ext, FILE2.ext, FILE3.ext, FILE4.ext, FILE5.ext

    FILE1.ext

    This diff is too big for us to render.

    FILE1.ext

    This diff is too big for us to render.

    FILE1.ext

    This diff is too big for us to render.

    FILE1.ext

    This diff is too big for us to render.

    FILE1.ext

    This diff is too big for us to render.

  3. Glenn Fowler

    JDorman - Here's my version of the same problem: https://bitbucket.org/site/master/issue/4852/same-filename-repeated-on-changeset-view - I assume the BB number means they are tracking it internally.

    Dylan - Is there any way of getting at the information in the subsequent diffs? I'm entirely happy with your reasoning for limiting the run-time (and thus the amount displayed) by default, but a pull request that gets cut off half-way through is kind of hard to do an effective code review on.

  4. Log in to comment