Issue #4954 new

Can't revert a declined pull-request action (BB-6192)

Matthieu Perrot
created an issue

If someone of your team decline a pull request by mistake, you can't revert this operation even if your are the owner/manager of the repository with all admin rights. The alternative is to retry with a new pull-request, with the caveat of producing a spurious duplicate of the former pull-request.

In addition, it seems also strange that a pull request can be declined even if all participants have approved it !

Comments (81)

  1. Dylan Etkin

    Hi Matthieu,

    I think you are correct that we should allow you to re-open a declined PR.

    I would hesitate to not allow you to decline just because folks have approved. We are aiming for a light-weight approval system and I think that would start to dicate workflow a bit too much.

    Cheers,

    Dylan

  2. Christian Walther

    Seconding the wish for a possibility to reopen declined pull requests.

    I have a couple of pull requests that I have no idea how they ended up declined (the Activity tab shows no record of anyone declining them) (may have something to do with #4900), and I’d like to reopen them.

  3. Jon Anderson

    +11 for having a confirmation dialog if you try to decline a PR when one or more reviewers have approved it. Allow, but warn :) Ah... separate feature - I'll see if it exists and create a feature request if not.

    edit Issue #8346 created for this sidekick request

  4. Tyler Ebel

    Is this scheduled to be fixed at some point ? This a huge bummer that you can't reopen a pull request. Adds redundant process and wastes time.

  5. Dan Grystad

    +1 it would be a great feature. I think its very counter intuitive that decline is a dead end and not a step in the workflow of approving a pull request.

  6. Michael Bean

    I once removed a branch remotely and then pushed a new version, but a hook took that as a command to decline the PR. Just because it was empty for the 5 seconds I took between commands doesn't mean I wanted to decline it. I just wanted to swap out the code for the right code. (So if a branch is empty, it is still a valid PR...just with no diff to show.)

    Maybe this is another problem, but is related and was the main cause of accidental irreversible DECLINEs on PRs.

  7. David Meister

    Is this really a feature request or a massive bug in the system? This really needs to be fixed. It's been 2 years since this thread was opened (I'm willing to bet that Atlassian internally knew about this issue long before it was publicly reported) and there's still a largely undocumented button that FUBARs your PRs prominent in the UI.

  8. Michael Bean

    No idea...could the creator of this request please change it to a non-minor priority? I don't think it should be difficult at all to be able to flip a boolean in the database (declined/not).

  9. Michael Bean

    I agree. But the fix should be fairly intuitive.

    On a positive note, it looks like the decline button, even if accidentally hit will request the user to provide a reason to decline, which mitigates the possibility of accidentally pushing the button. I don't have much of a problem with the button itself. I have a problem with the fact that the PR was automatically declined when the branch was removed. Now that I know more about BB, I wonder if there was a hook involved. I'm going to look into that...

  10. Michael Bean

    Yeah, looks like there is a "hook" involved that can't be disabled. The PR realizes that there is nothing to commit and determines that that means "decline". Git can revert reverts, so it makes sense to be able to undo a decline. I vote for the ability to reverse a decline.

  11. Rick Cuddy

    +1 etc etc

    Really want a workflow based around declining because of problems that can and should be fixed, to replicate workflows such as Phabricator where approval indicates request can be merged, where decline indicates work remains to be done.

  12. Victor Engel

    +1 I also just declined a PR and can't reverse the decline. Not good. I declined because of a perceived problem. When the problem is resolved, the PR should be able to proceed.

  13. Anonymous

    This was first brought up as an issue 3 years ago. How long does it take Atlassian to implement features? Yes, don't dictate workflow, but also do not tie our hands. I have several comments to create tasks from a pull request that has already been declined. In not allowing us to re-open it, you've already dictated workflow.

  14. Tri Nguyen

    Please vote and not comment a "+1". You can also follow this issue by watching it. This will avoid spamming all existing watchers with the noise. Perhaps we should say this explicitly in the description of the issue.

  15. Log in to comment