Issue #5026 resolved

Activity elements ordering is confusing

Sébastien Gautrin
created an issue

In the activity tab of pull requests, the order of elements is not correct. Indeed, when alternating updating the pull request with new commits and commenting on it, one would expect to have this alternance in the activiy tab.

Instead, the activity tab will show all the changesets added to the pull request on a given day, and then only all comments.

For example, with changes added to the pull request on October 19, 10:00 (changeset1), October 19, 16:00 (changeset2) and October 20, 12:00 (changeset3), and with comments added October 19, 12:00 (comment1), 14:00 (comment2) and October 20, 10:00 (comment3) and 14:00 (comment4).

The expected activity tab would show (most recent first):

  • comment4
  • changeset3
  • comment3
  • changeset2
  • comment2
  • comment1
  • changeset1

Instead, it shows:

  • comment4
  • comment3
  • changeset3
  • comment2
  • comment1
  • changeset2
  • changeset1

Comments (7)

  1. Sébastien Gautrin reporter

    Hmm, looking at it more, it doesn't seem to be always like I had encountered and explained before. I guess I just can't figure out exactly what are the ordering criteria for this panel; though I suppose what's confusing me here has to do with the discussion threads in that panel which leads to not being really able to see at a glance what happened when.

  2. Patrick Kaeding

    Hi Sébastien

    The way it works is that most recent 'units' are on top. A 'unit' is a PR update event, like adding commits, changing the state, approvals, etc, or an entire comment thread.

    This allows comment threads to bubble up to the top as they are updated.

    I hope that clarifies what's going on!

    Thanks, Patrick

  3. Sébastien Gautrin reporter

    Indeed that clarifies it. Though in the end having the whole thread move up make it not so easy to identify what was actually new in the comments nor when they happened with regards to the commits (even more as commits only show the date of the update, not the time).

  4. Log in to comment