When viewing a commit, clicking a comment link that was created "off page" ("show more lines") will not display that comment (BB-7569)

Issue #6415 duplicate
Tom Clift
created an issue

Sometimes when reviewing a commit one will want to browse beyond the default lines that were displayed (by clicking "show more lines") and create a comment there. When another user wants to view this comment they can click the comment link at the top, which will take them to the default lines that were displayed, but the comment will be still off page for them (they will also need to click "show more lines" to see it, but now they don't know if they need to go up or down, and how far).

When there are "off page" comments, these should be displayed.

I would suggest displaying the comment lines like change lines and displaying them along with the default 3 lines of context.

Comments (4)

  1. Brian Nguyen

    Hi Tom,

    Thanks for reporting. The diff view should be automatically expanding the diff if there are "hidden" comments. From my testing, this does not occur if the comment is more than 4 lines away from the default context.

    I have added this to our backlog and we will look into this when we can.

    Cheers, Brian

  2. Tom Clift reporter

    .#5196 was reported 2012-11-02 and claimed fixed 2012-11-10.

    This issue was reported 2013-02-18, so it's more like a regression than a duplicate.

    In any case, the feature seems to be working now.

  3. Jonathan Poh staff

    It might have been a regression at the time, but I have been unable to reproduce it so it probably got fixed sometime since the date it was reported. However, there is a related, but subtly different bug relating to comments on context lines sometimes being hidden which we've already been tracking internally, and I've raised a new issue #12368 for it.

  4. Log in to comment