Issues

Issue #6525 resolved

receiving email notification for pull requests for repositories without write access

Marcin Kuzminski
created an issue

I got it for sqlalchemy, and webHelpers

Comments (13)

  1. Erik van Zijst staff

    Can you be more specific? Which repos exactly and which pull requests? If you want you can forward one of the emails to erik@atlassian.com

    Note that even if you are not a writer and you're not watching a repo, somebody can still explicitly add you to a pull request as a reviewer and then you would still get an email. Can you check if that's what happened? You would be listed as a reviewer on the PR overview page.

  2. Erik van Zijst staff

    Actually, is it possible that these pull requests pre-date our recent pull request reviewer changes? The behavior we have now (notifications being sent only if you are a writer and watching the repo) don't retroactively apply to existing pull requests.

    In that case you can simply unwatch the PRs in question and that should be it.

  3. Erik van Zijst staff

    It's a bug if bitbucket added you as a reviewer without you having been a writer and a watcher at the time the PR was created.

    Another way through which you can become a watcher involuntarily is when somebody on the PR mentions your name (this does not appear to be the case here, but wanted to make that clear nonetheless).

    Can you please unwatch them both and reopen this issue should it happen again?

  4. jmagnusson

    I've recently started getting email notifications for pull requests as well (from repos which I don't have write access to). I've never actively subscribed to the issues.

    These two are the pull requests which I've gotten notifications for: https://bitbucket.org/izi/django-admin-tools/pull-request/17/fixes-in-migrations-in-order-to-support https://bitbucket.org/andrewgodwin/south/pull-request/106/added-mysql_oursql-to-engine_modules/diff

    Should I really have to actively unsubscribe to each pull request just because I'm following the repo? Maybe I'm misinterpreting "Following" as the equivalent of Github's "Starred"? I'd just like to star the repos like I do with Github so that I can find them easily, not get swarmed by email notifications for every pull request that is created.

  5. Erik van Zijst staff

    Yep, earlier this morning we've traced this to a regression we made when we released our "smarter PR notifications" (the irony).

    We're planning to roll a hotfix later today, but unfortunately that will not be retroactive (meaning that it won't fix PRs you are currently getting emails for).

  6. Erik van Zijst staff

    FYI: the bug makes everyone who follows a repo (even if you don't have write access) a watcher. So if you unfollow a repo, you won't get added as a watcher to new PRs.

  7. Zach Davis staff

    The bug that was causing this has been fixed and deployed. As Erik mentions above, this fix will not remove you from watching any existing pull requests (you'll have to do that manually), but it will fix it for any future pull requests.

    Sorry for the inconvenience.

  8. Log in to comment