1. Bitbucket
  2. Public Issue Tracker
  3. master
  4. Issues

Issues

Issue #6595 resolved

Cannot comment on diff that wasn't displayed because the pull request has lots of files (BB-7787)

Monica Nguon
created an issue

One of our pull requests (PR12 of telemetris account) concerns 100 files.

Only the 68 first diffs are displayed, while all remaining files diffs have to be displayed manually by clicking on: This diff was too big for us to render on page load. Click here to try to load it

This wouldn't be an issue, if these manually displayed diffs could be commented:

  1. Go to pull request page.
  2. Scroll to files list, and click on a file in the end of the list.
  3. The diff of the selected file is displayed.
  4. Click to display the "Add comment" form.
  5. Input a comment.
  6. Click on the "Comment" button.
  • Expected result: The new comment is added to the file diff.
  • Result: Nothing happens: 500 error is raised: POST https://bitbucket.org/!api/1.0/repositories/telemetris/tqr/pullrequests/12/comments/ 500 INTERNAL SERVER ERROR 6.7s

Comments (10)

  1. Monica Nguon reporter

    We are now able to add comments to diffs that had to be displayed initially, thanks!

    However, could you please confirm that the following behaviors are expected? If not, I will open a new issue.

    • Comments made on prior versions of a file are usually displayed in a modal window.
    • If the diff was displayed manually, we are simply taken to the Activity tab.
  2. Erik van Zijst staff

    Comments made on prior versions of a file are usually displayed in a modal window.

    Correct.

    If the diff was displayed manually, we are simply taken to the Activity tab.

    No, that doesn't seem right. Please raise a separate issue for that.

  3. Log in to comment