Unable to add comment to binary file in pull request

Issue #6835 resolved
Éric Araujo
created an issue


For binary files, it would make sense to allow people to make a comment on the file (since there are no lines), for example to point an issue in the file name or the file content itself (especially if it’s an image: we can see the content right here).

I’ve worked around this by putting the comment on the last line of the file before, but 1) I was lucky that this image was preceded by a text file, 2) it does not appear near the image in the activity tab, 3) the comment was banished to the somewhat impractical “comments on previous diff” popup after the text file was updated.

Comments (8)

  1. Zachary Davis

    Hi Éric,

    What luck! We just deployed this feature yesterday. You should now see an "Add comment" icon when you hover over the filename of a binary file. Hopefully, this should solve all three of your concerns.

    Cheers, Zach

  2. ExecuteSales Ltd

    Hi Zach,

    I have the same issue as Eric but somehow I cannot see the "Add comment" icon on either the web interface or Sourcetree. Sorry for the stupid question I'm a novice to this. Thanks!


  3. ExecuteSales Ltd

    Thanks - that's what I thought but I don't see an icon popping up anywhere when hovering over the filename. Can I add the comment in Sourcetree or what is the environment where you are supposed to see the icon? Thanks very much for your help!

  4. ExecuteSales Ltd

    Ok, now that I figured it out in principle 2 questions:

    1) The little icon appears and works fine in COMMITS. It appears and does not work in SOURCE. Is this a bug?

    2) Why do I not see the comments anywhere in SOURCE? This would definitely make working with the comments across versions much easier



  5. Michael Frauenholtz staff

    Hi Martin,

    1) The icon to add comments should not be appearing in the source browser. If it is showing up, that is a bug (if so, can you post a screen shot of that, or tell us exactly where you're seeing it?).

    2) Right now our comments are only visible on commits and pull requests. We have issue #5587 open for a request to add comments to the source browser.

    Let me know if there's anything else we can help you with!


  6. Log in to comment