Ability to approve files individually in a pull request (BB-9145)

Issue #7968 wontfix
Andre Foresti
created an issue

It's hard to review large pull requests with a lot of files. So it would be nice to mark as approved some files that you are sure that are ok. It would be nicer if these files that you already reviewed, be collapsed so you didn't have to look at them anymore, unless they have changed again.

A mark on the side of the files that I approve on the list of changed files would be nice too.

Official response

  • Alastair Wilkes staff

    Hi there,

    At this time and for the near future it is more likely that we will solve these use cases by implementing #14889 iterative review (or commit-by-commit review) similar to what's available in Bitbucket Server. This feature would let you review files commit-by-commit so you only have to review new changes.

    I think it's unlikely that we'll add file level approval anytime soon - that level of granularity, combined with merge checks, and combined with iterative review, would introduce more UX complexity than we'd like.

    This could change as we make more changes to the UI and get more feedback, but for the next 6-12 months I think it's more likely we'll solve this with commit-level review, not individual-file review.

    Thanks,
    Alastair
    Bitbucket PM

Comments (22)

  1. Richard Quadling

    The general idea is to be able to focus the time I have on reviewing to actually reviewing, not just scrolling through aspects that need no review.

    Allowing us to configure the acceptance of files modified purely for whitespace - PLEASE!!!!

    We have tooling to coerce the formatting as not all developers type the same (Long Live Whitesmith!!! say only me in my office! Sob!). So tooling corrects the styling, static analysis passes sanity, unit tests make sure nothing broke, code coverage does what it does. So, by the time things are in my lap as a reviewer, all the naming conventions, code complexity analysis, namespace usage, etc. have all been covered. I'm not interested in those aspects.

    This would be a REALLY useful feature. And will speed up reviewer's work.

  2. Andreas Klein

    Please also add this functionality to Bitbucket Cloud, not just the self-hosted edition.

    This really would be an extremely helpful improvement. We quote frequently have to go through multiple rounds of reviewing large pull request with dozens of files. Being able to mark anything that has been reviewed and approved, and to hide/collapse those files from the view on subsequent reviews, unless there were changes (ideally other than mere whitespace), would save a lot of time and make the process a lot less unpleasant.

  3. Alastair Wilkes staff

    Hi there,

    At this time and for the near future it is more likely that we will solve these use cases by implementing #14889 iterative review (or commit-by-commit review) similar to what's available in Bitbucket Server. This feature would let you review files commit-by-commit so you only have to review new changes.

    I think it's unlikely that we'll add file level approval anytime soon - that level of granularity, combined with merge checks, and combined with iterative review, would introduce more UX complexity than we'd like.

    This could change as we make more changes to the UI and get more feedback, but for the next 6-12 months I think it's more likely we'll solve this with commit-level review, not individual-file review.

    Thanks,
    Alastair
    Bitbucket PM

  4. Andy Coates

    @Alastair Wilkes - Regarding commit-by-commit reviews - in an ideal world, everyone would craft beautiful commits that were logically isolated. But the reality is that commits in a branch often undo things that happened in earlier commits (ie. where the first implementation of an idea didn't quite work out), so reviewing on a commit basis would waste a lot of time.

  5. Alastair Wilkes staff

    @Andy Coates - That's definitely true in some cases. That said, commit-by-commit review wouldn't be mandatory; you'd be able to see changes across any range of commits in the PR (including the entire range, like what is shown today). This is especially. useful for "show me what's changed since I last reviewed." Either way, we don't plan to add file-level review states (where some files are approved and some aren't) any time soon.

  6. Log in to comment