When a PR is updated (with new commit changes), more reviewers are added!

Issue #8565 invalid
Peggy Kuo
created an issue

Opened a PR with 3 reviewers (or maybe 2?) and received some comments/stuff to fix.

Pushed to the branch with the fixes, and got the tooltip from the edit button to "update" as changes had been detected.

After updating, there is now 6 reviewers on the list!

I think it automagically added the 'suggested reviewers' when it updated the PR :(

Comments (10)

  1. Erik van Zijst staff

    Are you sure that's what happened, or is merely the people that had commented on your PR (these are "participants", not "reviewers", but show up in the same list)?

  2. Erik van Zijst staff

    I'm unable to reproduce this. That bottom list is indeed the list of suggested reviewers, but as long as you don't click them to move them to the reviewers input, they shouldn't get added.

    Can you confirm whether this happens again if you click save?

  3. Peggy Kuo reporter

    Hm, that's odd. I could be wrong (as I don't remember the exact list of reviewer names originally) though I know I only added at most 3 reviewers, and then after the update it suddenly became 6 reviewers.

    The extra reviewers didn't happen when I clicked save from the edit page, it (probably) happened when I clicked 'update' when viewing the PR and that option became available via the edit button (because I had pushed a commit to that branch)

    Will let you know if i notice it happening again.

  4. Log in to comment