Unicode characters in commit description

Issue #52 resolved
Anonymous created an issue

When trying to review repo with some polish characters there is exception: "UnicodeDecodeError: 'ascii' codec can't decode byte 0xc4 in position 17: ordinal not in range(128)" I do not know why there is ascii codec, my system is OS X using unicode everywhere.

I have come with a quick fix that solves the problem for me: {{{ diff --git a/review/templates/index.html b/review/templates/index.html --- a/review/templates/index.html +++ b/review/templates/index.html @@ -14,7 +14,7 @@ <tr> <td class="node"><span class="rev">{{ rev.rev() }}</span><span class="sep">:</span><span class="hash">{{ node_short }}</span></td> <td class="desc"> - <a class="changeset-link" href="{{ link }}">{{ rev.description().splitlines()[0] }}</a> + <a class="changeset-link" href="{{ link }}">{{ rev.description().splitlines()[0].decode('utf-8') }}</a> </td> <td class="stats"> {% with %}


Comments (4)

  1. Log in to comment