1. Steve Losh
  2. hg-review
  3. Issues
Issue #71 new

errors are suppressed when they should not be

created an issue

I recently had some trouble trying to change the default url for pull/push of review comments. I eventually ended up figuring out the problem, but it was far too difficult to do so. Initially, the only error I saw from hgreview was:

hg review -w --address * Running on - - [25/May/2011 11:43:30] "POST /pull/ HTTP/1.1" 500 -

And a suggestion to report a bug report on the web page.

I was finally able to get something useful out of hgreview by running this instead: hg --debug --traceback --debugger review -v -v -v -v -w --address

Which pointed out that the error was: - - [25/May/2011 11:52:25] "POST /pull/ HTTP/1.1" 500 - Traceback (most recent call last): File "/shared/ehaszla/hg-review/bundled/flask/flask/app.py", line 965, in call return self.wsgi_app(environ, start_response) File "/shared/ehaszla/hg-review/bundled/flask/flask/app.py", line 955, in wsgi_app response = self.make_response(self.handle_exception(e)) File "/shared/ehaszla/hg-review/bundled/flask/flask/app.py", line 952, in wsgi_app rv = self.dispatch_request() File "/shared/ehaszla/hg-review/bundled/flask/flask/app.py", line 754, in dispatch_request return self.view_functionsrule.endpoint File "/shared/ehaszla/hg-review/review/web.py", line 212, in pull message=messages.FETCH, switch_parent=True, user='', date='') File "/mercurial-1.7.5/lib/python2.7/site-packages/hgext/fetch.py", line 57, in fetch raise util.Abort(_('outstanding uncommitted changes')) Abort: outstanding uncommitted changes

Errors like this should be displayed by default, although perhaps in a more readable manner, rather that hidden away.

Comments (0)

  1. Log in to comment