Commits

sk  committed 12caa2b

One step of refactoring to Launch framework.

  • Participants
  • Parent commits 7a4a5f4

Comments (0)

Files changed (3)

File src/org/lispdev/swank/LispImplementation.java

  */
 public abstract class LispImplementation
 {
-  protected String flispType = ""; // possible values SBCL, CLISP etc.
   protected boolean hasthreads = true;
 
   // Probably lisp implementation specific - tested with SBCL
     return fatalError;
   }
 
-  public String lispType()
-  {
-    return flispType;
-  }
-
   public boolean hasThreads()
   {
     return hasthreads;
    */
   public abstract boolean isValid();
 
+  public String quietCompilationWrap(String msg)
+  {
+    return msg;
+  }
+
+
   /**
    * TODO: figure out this method's signature.. ie how to pass SBCL init args
    *
       String pkg)
   {
     System.out
-      .println("Creating executable is not implemented for your CL implementation ("
-          + flispType + ")");
+      .println("Creating executable is not implemented for your CL implementation");
     return false;
   }
 

File src/org/lispdev/swank/SBCLImplementation.java

   {
     this.executable = executable;
     this.path = sbclDirectory;
-    flispType = "SBCL";
     if( System.getProperty("os.name").toLowerCase().contains("windows") )
     {
       hasthreads = false;
   }
 
   @Override
+  public String quietCompilationWrap(String msg)
+  {
+    return "(locally (declare (sb-ext:muffle-conditions sb-ext:compiler-note)) "
+        + msg + ")";
+  }
+
+  @Override
   public Process start(String loadPath, int port) throws IOException
   {
     System.out.println("start");

File src/org/lispdev/swank/SwankInterfaceCore.java

     synchronized(port)
     {
       ++port;
-      System.out.println("----------------implementation:"
-          + implementation.lispType());
+      System.out.println("----------------implementation:");
 
       String slimePath = pluginDir + "slime/swank-loader.lisp";
       System.out.println("----------------slimePath:" + slimePath);
     return (retries > 0);
   }
 
-  public String quietCompilationWrap(String msg)
-  {
-    if( implementation.lispType().equalsIgnoreCase("SBCL") )
-    {
-      return "(locally (declare (sb-ext:muffle-conditions sb-ext:compiler-note)) "
-          + msg + ")";
-    }
-    else
-    {
-      return msg;
-    }
-  }
-
   public void reconnect()
   {
     disconnect();
     return displayListener.fetchText();
   }
 
+  public String quietCompilationWrap(String msg)
+  {
+    return implementation.quietCompilationWrap(msg);
+  }
+
 }