Unbundle cryptokit / SKS incompatible with ocaml 4.03

Issue #42 resolved
Kristian Fiskerstrand
created an issue

We're tracking this downstream in [0] but this is likely a better place to discuss this issue.

ocaml 4.03 removes defined types such as uint32[1,2] which is used by cryptokit for e.g stubs-md5.c. There are three different alternative ways to proceed to make SKS compatible with this change: (i) Patch the current bundled cryptokit (1.7) to use uint32_t instead (ii) Upgrade the version of cryptokit distributed to a version that has this fixed (iii) completely unbundle cryptokit

Now, I'm generally not a fan of bundling of libs for security tracking purposes etc, is it time for us to not embed this for next release?

References:

[0] https://bugs.gentoo.org/show_bug.cgi?id=591326

[1] http://caml.inria.fr/mantis/view.php?id=6517

[2] https://github.com/andrenth/ocaml-uint/issues/8

Comments (11)

  1. Kristian Fiskerstrand reporter

    So far this works up to version 1.10 of cryptokit, however starting with 1.11 I get s_do.cmx unit_tests.cmx sks.cmx File "none", line 1: Error: No implementations provided for the following modules: Z referenced from /usr/lib64/ocaml/cryptokit/cryptokit.cmxa(CryptokitBignum) make: *** [Makefile:180: sks] Error 2

    NOTE: External deps, findlib and cryptokit

  2. Kristian Fiskerstrand reporter

    Next step for patch is to allow direct specification of library path in Makefile.local , if this is specified we avoid the findlib query, this can also allow packagers or others building to have cryptokit in an own directory in build area

  3. Log in to comment