please allow to specify hostnames for hkp_address and recon_address and service names for hkp_port and recon_port

Create issue
Issue #9 invalid
Christoph Anton Mitterer created an issue


The following two features would be nice to see: 1) That one my specify service names instead of the numbers for hkp_port and recon_port. You can use getservent(3) to query the system's service DB (e.g. /etc/services)

2) The same for hostnames for hkp_address and recon_address It's often helpful if one can simply define an alias in /etc/hosts and services determine the addresses they should bind to from that. The advantage is that when the IP changes, you don't have to go through all the services configurations, but simplty change it at one place. gethostent(3) is your friend.

Cheers, Chris.

Comments (4)

  1. John Clizbe

    Your item #2 has been fully supported since 2009. Wherever did you get the idea that host names were not supported? What a hostname is used sks will bind to all addresses associated with that name -- this is not always desired behavior.

    The man page is your friend. See the entries for hkp_address and recon_address

    The code is also your friend. See around line 211 or so

    basket:sks-work jpclizbe$ hg log -r 34 changeset: 34:c77aab222f08 user: Kim Minh Kaplan date: Sun Aug 30 17:40:24 2009 +0200 files: sks.pod description: Call Unix.getaddrinfo on both hkp_address and recon_address.

    basket:sks-work jpclizbe$ hg log -r 35 changeset: 35:95926d02fe80 user: Kim Minh Kaplan date: Mon Aug 31 23:33:41 2009 +0200 files: sks.pod description: Fix documentation to explicit that hkp_address and recon_address can contain both IP addresses and domain names.

  2. Christoph Anton Mitterer reporter

    Hi John.

    You're right, the manpage already tells it. But "-help" mentions just "address" which is usually not a hostname. So perhaps one can just add hostname there as well :)

    So I guess (1) stays open as a whishlist request and (2) becomes: mention this in the -help output as well :-)

    Best wishes, Chris.

  3. John Clizbe

    committed fix for help to be more explicit: changeset 357:21c4e07a1968

    I can't see where adding support for service port by name buys that much bang. If someone else is willing to do the work more power to them

  4. Log in to comment