1. Mike Orr
  2. patch-WebHelpers


slug...@gmail.com  committed d58f6c7

Put hidden "_method" field of ``form()`` in a <div>, and add an arg for additional hidden fields.

  • Participants
  • Parent commits cff5a69
  • Branches trunk

Comments (0)

Files changed (2)


View file
  • Ignore whitespace
     The exact spacing is subject to change.  The tag building code has been
     refactored to accommodate this.
 * webhelpers.html.tags:
+  - ``form()`` puts its hidden "_method" field in a '<div style="display:none">'
+    to conform to XHTML syntax. The style prevents the div from being displayed
+    or affecting the layout. A new arg ``hidden_fields`` may be a dict or
+    iterable of additional hidden fields, which will be added to the div.
   - Set magic ID attribute in ``hidden`` helper to match behavior of the other
     tag helpers.
   - ``image()`` can now calculate the width and height automatically

File webhelpers/html/tags.py

View file
  • Ignore whitespace
 NL = literal("\n")
 BR = literal("<br />\n")
-def form(url, method="post", multipart=False, **attrs):
+def form(url, method="post", multipart=False, hidden_fields=None, **attrs):
     """An open tag for a form that will submit to ``url``.
     You must close the form yourself by calling ``end_form()`` or outputting
-    ``multipart``
-        If set to True, the enctype is set to "multipart/form-data".
-        You must set it to true when uploading files, or the browser will
-        submit the filename rather than the file.
         The method to use when submitting the form, usually either 
         "GET" or "POST". If "PUT", "DELETE", or another verb is used, a
         hidden input with name _method is added to simulate the verb
         over POST.
+    ``multipart``
+        If set to True, the enctype is set to "multipart/form-data".
+        You must set it to true when uploading files, or the browser will
+        submit the filename rather than the file.
+    ``hidden_fields``
+        Additional hidden fields to add to the beginning of the form.  It may
+        be a dict or an iterable of key-value tuples. This is implemented by
+        calling the object's ``.items()`` method if it has one, or just
+        iterating the object.  (This will successfuly get multiple values for
+        the same key in WebOb MultiDict objects.)
+    Because input tags must be placed in a block tag rather than directly
+    inside the form, all hidden fields will be put in a 
+    '<div style="display:none">'.  The style prevents the <div> from being
+    displayed or affecting the layout.
     >>> form("/submit")
     >>> form("/submit", method="get")
     literal(u'<form action="/submit" method="get">')
     >>> form("/submit", method="put")
-    literal(u'<form action="/submit" method="post"><input name="_method" type="hidden" value="put" />')
+    literal(u'<form action="/submit" method="post"><div style="display:none">\\n<input id="_method" name="_method" type="hidden" value="put" />\\n</div>\\n')
     >>> form("/submit", "post", multipart=True) 
     literal(u'<form action="/submit" enctype="multipart/form-data" method="post">')
+    Changed in WebHelpers 2.0b2: add <div> and ``hidden_fields`` arg.
+    fields = []
+    attrs["action"] = url
     if multipart:
         attrs["enctype"] = "multipart/form-data"
-    method_tag = literal("")
     if method.lower() in ['post', 'get']:
         attrs['method'] = method
         attrs['method'] = "post"
-        method_tag = HTML.input(type="hidden", name="_method", value=method)
-    attrs["action"] = url
-    return HTML.form(method_tag, _closed=False, **attrs)
+        field = hidden("_method", method)
+        fields.append(field)
+    if hidden_fields is not None:
+        try:
+            it = hidden_fields.items()
+        except AttributeError:
+            it = hidden_fields
+        for name, value in it:
+            field = hidden(name, value)
+            fields.append(field)
+    if fields:
+        div = HTML.div(*fields, style="display:none", _nl=True)
+    else:
+        div = None
+    return HTML.form(div, _closed=False, **attrs)
 def end_form():