Tag Creation causes email trigger for Branch deletion

[Ed Meagher]

Whenever we tag a commit, we get an email with the subject:

[2a4952c..0000000@2a4952c97eea14b151af6d4955582c319fbabe4b] Branch deleted

and the body:

Branch DELETED by XXX XXXXX - [e-mail]

(The body does contain a real email and name).

This seems like a bug but I might not be understanding how BitBucket/Git works.

[Marc Vanbrabant]

Hi @ed_meagher

could you describe which git commands you execute to create your tag and push them?

changeset ending on 0000000 marks that this changeset is "deleted". Are you in detached head of some sorts?

Following commands mails just fine: * git tag some_tag * git push --tags

[Ed Meagher]

It turns out that this "Branch Deleted" email only happens when I use the "Tag Maker" plugin to create the tag. (https://marketplace.atlassian.com/plugins/be.contribute.atlassian.stash-tagging-support/server/overview). When I used a git client to make the tag I get a "Tag Created" email which is appropriate.

I don't know what commands the "Tag Maker" plugin uses to create the tag.

[Dakota Hawkins]

I am actually having exactly the opposite problem. Tag deletion causes email trigger for branch creation!

Following the e-mail subject template on your master branch, I switched the $isDeletedBranch check to be before the $isNewBranch check to make sure both aren't true. It appears that $smtpNotificationRenderer.isDeletedBranch( $refChange ) just doesn't work properly for tags.

I was creating and deleting tags (to test my changes to the subject template) by creating and deleting them directly from Bitbucket Server's commit details page.

Similarly, I created and deleted a branch, and those were correct.

[John Chittum]

Having a related issue--when using the Tag Maker plugin to create a tag, an email is sent stating "Tag DELETED"

The Tag Maker maintainers said their code returns the proper dialogue

The Tag Maker : 1.3.4

Push email notifier: 3.2.2