List.iteri doesn't have the 'right' signature

[leonidr]

I don't know if you care about this but:

a list -> f:(int -> 'a -> 'b) -> unit

[Sebastien Mondet]

That's interesting; I never noticed because I always build with -strict-sequence.

$ ocaml
...
#   let iteri l ~f =
      ignore (fold l ~init:0 ~f:(fun i x -> f i x; i + 1))
 ;;
  val iteri : 'a list -> f:(int -> 'a -> 'b) -> unit = <fun>

Vs

$ ocaml -strict-sequence
...
#   let iteri l ~f =
      ignore (fold l ~init:0 ~f:(fun i x -> f i x; i + 1))
 ;;
  val iteri : 'a list -> f:(int -> 'a -> unit) -> unit = <fun>

Hence, is this a bug or a feature (i.e. we obey the user preference of not using the -strict-sequence)?

[leonidr]

I do think of it as a bug as I wouldn't want the code to compile unless f does has a unit return type, which I experienced yesterday. But, this is trivial, I threw up a PR since I raised this issue.

[Sebastien Mondet]

PR #2 fixed this.