BestInspection contains closed schools

[Ghislain Hachey]

warehouse.BestInspections contains schools that are closed. Ideally they should not. Many tables/views then depend on this and thus provides slightly unexpected data. For example, total cumulative schools analyzed in 2021 are 183 when we known there are only 182 schools. This raises questions with people looking at our reports.

I believe an adjustment to warehouse.BestInspection and warehouse regeneration would have the more expected behavior. We’ll end up with less then 182 schools in the total count but that is because some schools likely to not have a loaded school accreditation.

[Ghislain Hachey]

I think the small change below does the desired results. Needs closer scrutany by @Brian Lewis

... urgh…not really this will exclude closed schools in prior years also when they were not closed (need to add year closed in the join I think.)

‌

The below seems to work a bit better.

‌