Change workbook to use AuthorityGroup for Public / Private

Issue #611 resolved
Brian Lewis repo owner created an issue

Current schLandOwner holds public or private ; but this should be defined by Authority Group.

Use that value - but change code values from

Government to Public

Non-Government to Private

relates to #603

Comments (5)

  1. Ghislain Hachey

    @Brian Lewis this is a blocker as when migrating an previous workbook version all the Public/Private data is lost and turned into 0. They previously where stored in School Type (which is what is the vocab here in RMI and FSM).

    Can we also start making use of the vocab in the workbook? (Remove hard coded State, etc.)

  2. Ghislain Hachey

    Current schLandOwner holds public or private ; but this should be defined by Authority Group.

    Use that value - but change code values from

    Government to Public

    Non-Government to Private

    relates to #603

  3. Brian Lewis reporter

    migrating an previous workbook version all the Public/Private data is lost

    I don't think that’s the issue.

    School type on every sheet is not editable - it is calculated. It is derived from the list of schools. In older versions, it came from schLandOwner. Now it comes from AuthorityGroup, which is in turn derived from the school authority.

    This appears to be set up correctly for all schools. If you look at SchoolList sheet the two columns schLandOwner and AuthorityGroup have the same value. Non of the reporting uses schLandOwner so we shouldn't rely on this usage. AuthorityGroup by contrast is everywhere accessible in the warehouse.

    Note that when you do a Merge, it checks whether a column in the destination table is calculated ( ie has a formula in the first row), and if it is that column is not merged from the source data. So when you Merge a list of schools, the School Type column is recalculated - by looking up the AuthorityGroup in SchoolsList.

    Sending via skype the latest RMI.xlsm version date 25/5/2019 which deals with a formula refresh problem i noticed after doing merge.

  4. Log in to comment