Not working without Internet Connection
Issue #69
closed
Notice this during one of my daily power brownouts. Application does not work at all without Internet. Fix and provide a user friendly message to users in places where Internet is needed (e.g. maps).
Comments (8)
-
repo owner
-
reporter
-
assigned issue to
Ghislain Hachey
I'll look into this and see if I can do as you suggest.
-
assigned issue to
-
reporter
Is ngMap used? I see the script is loaded but I don't see a single call to NgMap as in the ngMap docs. Maybe you use gmaps.js directly? Because ngMap recommends simply using map-lazy-load to address the no Internet problem.
-
reporter
Can this issue be addressed with the work on remote/local downloading of resources?
-
repo owner
We have been using quite an old version of ng-map, and the directive has b=even changed name (from map to ng-map) since this version 1.1.8 . So I think first step is to pull in the current version, then try the lazy loader.
-
repo owner
I will take this over.... and assign to myself
-
repo owner
-
assigned issue to
Brian Lewis
-
assigned issue to
-
repo owner
- changed status to closed
merged issue69 branch
- Log in to comment
Yep - spot on, its google maps that breaks this. And in particular, the google map angular directive we use fails if google maps is not available, and therefore we can't create the main module which is a dependency on that.
In test\stubs there a little file that defines the interface for google maps - this is loaded in some test pages in lieu of loading google maps - and it allows things to load and work (except mapping of course).
One possiblility would be to load code like this, then allow google maps to load over it, or if it can't the http fail will not stop the application - becuase we still have a window.google.