Only display workbook icon for survey records that have one [2022:HPR]

[Ghislain Hachey]

Do not display icon for example for those surveys that were artificially created from appointments.

[Ghislain Hachey]

This is only needed for teachers it seems.

[Ghislain Hachey]

Digging into this I found the procedure responsible from “migrating” teacher appointments to TeacherSurveys: pTeacherAdmin.CreateSurveysFromAppointments. This was the solution to #322. However, as a result the UI gets broken links for workbooks. In particular, old records of TeacherSurveys as shown below.

My first thought was to add a new column the TeacherSurvey indicating whether the survey was a “true” survey or an artificially created one (migrated form appointed). But as I started doing this I noticed that was already a solution to this in the procedure. The tcheSource should actually have been set to an Appointment string as oppose to the file ID of the workbook loaded.

‌

The problem is that I see none of the TeacherSurvey records with this Appointment source. They all have a file ID which is impossible considering FSM has only been using the workbook for 3 years and we have appointments dating back 7 years. I would have expected everything 2014-17 to be from appointments.

So this is where I am now. And looking into where and how these “old” SchoolSurveys would exists.

[Ghislain Hachey]

Issue #953 was marked as a duplicate of this issue.

[Ghislain Hachey]

I believe this is sufficiently resolved by #1269