REview Census workbook validation of 'Duties', Salary

[Brian Lewis]

Commit 44242e7 introduces some detailed validation for Staff regarding the relationship between Staff Type ‘Teaching/ Non Teaching’ and the ‘Duties’ recorded ie GFrade levels taught, Admin or Other.

Specifically: a non-teacher cannot specify a grade level.

A non-teacher must specify either Admin or Other

A Teacher can leave everything blank, but if they specify Admin or Other, they must also have a grade level ( Otherwise, are they actually a non-teacher?)

Salary must be present unless Funding Source is Other.

Now, these will give us better results on Grade Level PTR, but they will generate a lot of detailed validations….

Please try out the upload of any of the new workbooks and see the effect, then please make a call as to whether you want these.

2nd point - some data fails validations because the sheet gets Unprotected and the workbook level validation is cleared. Should we prevent Unlocking the sheet? ie password control this?

@Ghislain Hachey please review and give me your thoughts on this.

[Ghislain Hachey]

@Brian Lewis I think preventing the unprotect might create frustrations. Is this just a matter of making sure it gets protected before saving and loading?

Regarding whether we want these additional data integrity and quality mechanisms in place I personally would be in favor. I will run it by Weison and David and get back to you. I will try it out now as well.