Commits

Luke Plant committed 8f94bc9

Fixed a few logic errors in email list creation.

  • Participants
  • Parent commits 42e9b86

Comments (0)

Files changed (1)

File contacts/lists.py

 
     for hg in HomeGroup.objects.exclude(group_email=''):
         if hg.group_email != '':
-            email_list = list(set([c.email for c in hg.contact_set.exclude(email='',
-                                                                           include_on_email_lists=False)]))
+            email_list = list(set([c.email
+                                   for c in hg.contact_set.exclude(email='').filter(include_on_email_lists=True)]))
             email_list_s = ', '.join(email_list)
             if hg.group_email in webfaction_email_list:
                 # Update:
                 s.create_email(hg.group_email, email_list_s)
 
     # Lists for all church members and all contacts
-    contacts = []
-    members = []
-    for c in Contact.objects.exclude(email='',
-                                     include_on_email_lists=False):
+    contacts = set()
+    members = set()
+    for c in Contact.objects.exclude(email='').filter(include_on_email_lists=True):
         if c.church_member:
-            members.append(c.email)
-        contacts.append(c.email)
+            members.add(c.email)
+        contacts.add(c.email)
 
-    s.update_email('church-contacts@christchurchbradford.org.uk', ', '.join(contacts))
-    s.update_email('church-members@christchurchbradford.org.uk', ', '.join(members))
+    s.update_email('church-contacts@christchurchbradford.org.uk', ', '.join(list(contacts)))
+    s.update_email('church-members@christchurchbradford.org.uk', ', '.join(list(members)))