jez...@bcc190cf-cafb-0310-a4f2-bffc1f526a37  committed eb53eaf

Fixed #16516 -- Relaxed the blocktrans rendering a little by falling back to the default language if resolving one of the arguments fails, raising a KeyError. Thanks, Claude Paroz and Aymeric Augustin.

  • Participants
  • Parent commits 341193d
  • Branches default

Comments (0)

Files changed (7)

File django/templatetags/

         result = re.sub(u'%(?!\()', u'%%', result)
         data = dict([(v, _render_value_in_context(context.get(v, ''), context)) for v in vars])
-        return result % data
+        try:
+            result = result % data
+        except KeyError:
+            with translation.override(None):
+                result = self.render(context)
+        return result
 class LanguageNode(Node):

File django/utils/translation/

         self.old_language = get_language()
     def __enter__(self):
-        activate(self.language)
+        if self.language is not None:
+            activate(self.language)
+        else:
+            deactivate_all()
     def __exit__(self, exc_type, exc_value, traceback):
         if self.deactivate:

File docs/ref/utils.txt

     useful when we want delayed translations to appear as the original string
     for some reason.
-.. function:: override(language)
+.. function:: override(language, deactivate=False)
     .. versionadded:: 1.4
     A Python context manager that uses
     :func:`django.utils.translation.activate` to fetch the translation object
     for a given language, installing it as the translation object for the
-    current thread and deinstalls it again on exit with
-    :func:`django.utils.translation.deactivate`.
+    current thread and reinstall the previous active language on exit.
+    Optionally it can simply deinstall the temporary translation on exit with
+    :func:`django.utils.translation.deactivate` if the deactivate argument is
+    True. If you pass None as the language argument, a NullTranslations()
+    instance is installed while the context is active.
 .. function:: get_language()

File docs/topics/i18n/internationalization.txt

 .. note:: The previous more verbose format is still supported:
    ``{% blocktrans with book|title as book_t and author|title as author_t %}``
+.. versionchanged:: 1.4
+If resolving one of the block arguments fails, blocktrans will fall back to
+the default language by deactivating the currently active language
+temporarily with the :func:`~django.utils.translation.deactivate_all`
 This tag also provides for pluralization. To use it:
     * Designate and bind a counter value with the name ``count``. This value will

File tests/regressiontests/i18n/other/locale/fr/LC_MESSAGES/

Binary file added.

File tests/regressiontests/i18n/other/locale/fr/LC_MESSAGES/django.po

+# This file is distributed under the same license as the PACKAGE package.
+msgid ""
+msgstr ""
+"Project-Id-Version: django tests\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2010-02-14 17:33+0100\n"
+"PO-Revision-Date: 2011-01-21 21:37-0300\n"
+"Last-Translator: Claude\n"
+"Language-Team: fr <>\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=2; plural=(n != 1)\n"
+#: template.html:3
+msgid "My name is %(person)s."
+msgstr "Mon nom est %(personne)s."

File tests/regressiontests/i18n/

 from django.conf import settings
 from django.template import Template, Context
 from django.test import TestCase, RequestFactory
+from django.test.utils import override_settings
 from django.utils.formats import (get_format, date_format, time_format,
     localize, localize_input, iter_format_modules, get_format_modules)
 from django.utils.importlib import import_module
 from patterns.tests import *
 from test_warnings import DeprecationWarningTests
+here = os.path.dirname(os.path.abspath(__file__))
 class TranslationTests(TestCase):
     def test_override(self):
         with translation.override('pl'):
             self.assertEqual(get_language(), 'pl')
         self.assertEqual(get_language(), 'de')
+        with translation.override(None):
+            self.assertEqual(get_language(), settings.LANGUAGE_CODE)
+        self.assertEqual(get_language(), 'de')
     def test_lazy_objects(self):
     def test_pgettext(self):
         # Reset translation catalog to include other/locale/de
         extended_locale_paths = settings.LOCALE_PATHS + (
-            os.path.join(os.path.dirname(os.path.abspath(__file__)), 'other', 'locale'),
+            os.path.join(here, 'other', 'locale'),
         with self.settings(LOCALE_PATHS=extended_locale_paths):
             from django.utils.translation import trans_real
         self.assertEqual(to_language('en_US'), 'en-us')
         self.assertEqual(to_language('sr_Lat'), 'sr-lat')
+    @override_settings(LOCALE_PATHS=(os.path.join(here, 'other', 'locale'),))
+    def test_bad_placeholder(self):
+        """
+        Error in translation file should not crash template rendering
+        (%(person)s is translated as %(personne)s in fr.po)
+        """
+        from django.template import Template, Context
+        with translation.override('fr'):
+            t = Template('{% load i18n %}{% blocktrans %}My name is {{ person }}.{% endblocktrans %}')
+            rendered = t.render(Context({'person': 'James'}))
+            self.assertEqual(rendered, 'My name is James.')
 class FormattingTests(TestCase):
     def setUp(self):
         self.old_locale_paths = settings.LOCALE_PATHS
-        settings.LOCALE_PATHS += (os.path.join(os.path.dirname(os.path.abspath(__file__)), 'other', 'locale'),)
+        settings.LOCALE_PATHS += (os.path.join(here, 'other', 'locale'),)
         super(LocalePathsResolutionOrderI18NTests, self).setUp()
     def tearDown(self):